Re: [v2,1/3] dt-binding: mediatek: mt8192: update mtk-wdt document
From: Matthias Brugger
Date: Thu Jul 30 2020 - 05:02:30 EST
On 30/07/2020 03:35, Crystal Guo wrote:
On Wed, 2020-07-29 at 18:18 +0800, Matthias Brugger wrote:
On 29/07/2020 12:02, Crystal Guo wrote:
update mtk-wdt document for MT8192 platform
should be two patches. one fixing the compatibles and second adding new board.
Signed-off-by: Crystal Guo <crystal.guo@xxxxxxxxxxxx>
---
Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index 4dd36bd..e36ba60 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -4,14 +4,15 @@ Required properties:
- compatible should contain:
"mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
- "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
+ "mediatek,mt2712-wdt": for MT2712
"mediatek,mt6589-wdt": for MT6589
"mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
"mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
"mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
- "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
+ "mediatek,mt8183-wdt": for MT8183
We will need to update the DTSI in a seperate patch as well.
Yes, this patch is based on
https://patchwork.kernel.org/patch/11690401/ , which modify description
for mt2712 and mt8183.
I don't understand your comment. This patch modifies the binding. The link you
provide is from an older version of the series (which is called v2 as well...)
So repeating myself: if you are updating the binding descritpion you will have
to update the dtsi as well as otherwise the binding and the dtsi are out of sync.
Regards,
Matthias