Re: [PATCH][next] mlxsw: spectrum_cnt: Use flex_array_size() helper in memcpy()

From: Gustavo A. R. Silva
Date: Thu Jul 30 2020 - 09:26:11 EST




On 7/30/20 04:21, Ido Schimmel wrote:
> On Wed, Jul 29, 2020 at 05:58:03PM -0500, Gustavo A. R. Silva wrote:
>> Make use of the flex_array_size() helper to calculate the size of a
>> flexible array member within an enclosing structure.
>>
>> This helper offers defense-in-depth against potential integer
>> overflows, while at the same time makes it explicitly clear that
>> we are dealing witha flexible array member.
>>
>> Also, remove unnecessary pointer identifier sub_pool.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>
> Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxxxx>
> Tested-by: Ido Schimmel <idosch@xxxxxxxxxxxx>
>

Thanks, Ido.

--
Gustavo