Re: [PATCH] arm64/alternatives: move length validation inside the subsection

[Catalin Marinas]

On Thu, Jul 30, 2020 at 08:13:05AM -0700, Sami Tolvanen wrote:
> On Thu, Jul 30, 2020 at 5:22 AM Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
> >
> > On Wed, Jul 29, 2020 at 02:51:52PM -0700, Sami Tolvanen wrote:
> > > Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement
> > > sequences") breaks LLVM's integrated assembler, because due to its
> > > one-pass design, it cannot compute instruction sequence lengths before the
> > > layout for the subsection has been finalized. This change fixes the build
> > > by moving the .org directives inside the subsection, so they are processed
> > > after the subsection layout is known.
> > >
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/1078
> > > Cc: <stable@xxxxxxxxxxxxxxx> # 4.14+
> >
> > Commit f7b93d42945c went in 5.8-rc4. Why is this cc stable from 4.14? If
> > Will picks it up for 5.8, it doesn't even need a cc stable.
> 
> Greg or Sasha can probably answer why, but this patch is in 4.14.189,
> 4.19.134, 5.4.53, and 5.7.10, which ended up breaking some downstream
> Android kernel builds.

I see but I don't think we need the explicit cc stable for 4.14. That's
why the Fixes tag is important. If a patch was back-ported, the
subsequent fixes should be picked by the stable maintainers as well.

-- 
Catalin