Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function âget_random_bytesâ; did you mean âget_random_onceâ?

From: Grygorii Strashko
Date: Thu Jul 30 2020 - 15:05:27 EST




On 30/07/2020 21:56, Linus Torvalds wrote:
On Thu, Jul 30, 2020 at 11:47 AM Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:


I'd like to note that below set of patches:
1c9df907da83 random: fix circular include dependency on arm64 after addition of percpu.h
83bdc7275e62 random32: remove net_rand_state from the latent entropy gcc plugin
f227e3ec3b5c random32: update the net random state on interrupt and activity

also break ARM build for the case:
#if defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6)

Lovely.

I think I'll have to revert 1c9df907da83 after all, and use Marc
Zyngier's patch to just remove that troublesome <asm/pointer_auth.h>
include in arm64 instead.

This turned out to be much messier than it should have been.

FYI. Below diff seems fixes build:

diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h
index f44f448537f2..1a3eedbac4a2 100644
--- a/arch/arm/include/asm/percpu.h
+++ b/arch/arm/include/asm/percpu.h
@@ -5,6 +5,8 @@
#ifndef _ASM_ARM_PERCPU_H_
#define _ASM_ARM_PERCPU_H_
+#include <asm/thread_info.h>
+
/*
* Same as asm-generic/percpu.h, except that we store the per cpu offset
* in the TPIDRPRW. TPIDRPRW only exists on V6K and V7


--
Best regards,
grygorii