Re: [PATCH v4] coccinelle: api: add kvfree script

From: Julia Lawall
Date: Fri Jul 31 2020 - 04:45:09 EST




On Fri, 31 Jul 2020, Markus Elfring wrote:

> >>> +msg = "WARNING: kmalloc is used to allocate this memory at line %s" % (k[0].line)
> >>> +coccilib.org.print_todo(p[0], msg)
> >>
> >> * I find the diagnostic text insufficient.
> >
> > I also find the message not very informative.
>
> Is it interesting how quick such views can change?

Yes. If one looks at something in context, one and understand it better
than the extract that you provided.

julia

> alpine.DEB.2.22.394.2007302214160.2548@hadrien/">https://lore.kernel.org/cocci/alpine.DEB.2.22.394.2007302214160.2548@hadrien/
> https://systeme.lip6.fr/pipermail/cocci/2020-July/008041.html
> https://lkml.org/lkml/2020/7/30/1015
>
> ââ
> Actually, the message looks fine. Sorry for the noise about that.
> ââ
>
>
> Can such notifications become more helpful?
>
> Regards,
> Markus
>