Re: [PATCH] lib: Convert test_uuid.c to KUnit

From: Arpitha Raghunandan
Date: Fri Jul 31 2020 - 06:02:49 EST


On 31/07/20 11:20 am, Brendan Higgins wrote:
> On Thu, Jul 30, 2020 at 5:18 AM Arpitha Raghunandan <98.arpi@xxxxxxxxx> wrote:
>>
>> Converts test lib/test_uuid.c to KUnit
>
> Can you add some more detail to the commit message? Maybe link to
> KUnit and say something about why this change is beneficial.
>
Sure, I will make this change.
>> Signed-off-by: Arpitha Raghunandan <98.arpi@xxxxxxxxx>
>
> Change mostly looks good to me.
> Thank you for the review.

On failure, the original test calls another function which prints a detailed error. I removed it when converting to KUnit. Is this required?