Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+

From: Gustavo A. R. Silva
Date: Fri Jul 31 2020 - 13:01:58 EST


On Fri, Jul 31, 2020 at 09:35:42AM -0700, Joe Perches wrote:
> On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> > Increase columns highlighting to 100+ once the 80-column warning has
> > been deprecated in the Linux kernel[1].
> >
> > [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > ---
> > plugin/linuxsty.vim | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> > index 6f7e331..c42ce72 100644
> > --- a/plugin/linuxsty.vim
> > +++ b/plugin/linuxsty.vim
> > @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> > setlocal tabstop=8
> > setlocal shiftwidth=8
> > setlocal softtabstop=8
> > - setlocal textwidth=80
> > + setlocal textwidth=100
>
> This is not a good change.
> 80 columns is still _preferred_.
>

Now that you mention that, I have mixed feelings about this.
Let's see if we can get more opinions...

--
Gustavo

>
> > setlocal noexpandtab
> >
> > setlocal cindent
> > @@ -80,7 +80,7 @@ function s:LinuxHighlighting()
> > highlight default link LinuxError ErrorMsg
> >
> > syn match LinuxError / \+\ze\t/ " spaces before tab
> > - syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
> > + syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
> >
> > " Highlight trailing whitespace, unless we're in insert mode and the
> > " cursor's placed right after the whitespace. This prevents us from having
>