Re: [PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

From: Florian Fainelli
Date: Sat Aug 01 2020 - 16:48:52 EST

On 8/1/2020 10:05 AM, Jonathan McDowell wrote:
> Rather than using a magic value of 1 when configuring the port VIDs add
> a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the
> bitmask in the process; the top 4 bits are reserved so this wasn't a
> problem, but only masking 12 bits is the correct approach.
> Signed-off-by: Jonathan McDowell <noodles@xxxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>