Re: [PATCH] iio: trigger: sysfs: Disable irqs before calling iio_trigger_poll()

From: Lars-Peter Clausen
Date: Sun Aug 02 2020 - 11:06:00 EST

On 8/1/20 6:02 PM, Jonathan Cameron wrote:
On Mon, 27 Jul 2020 16:57:13 +0200
Christian Eggers <ceggers@xxxxxxx> wrote:

iio_trigger_poll() calls generic_handle_irq(). This function expects to
be run with local IRQs disabled.
Was there an error or warning that lead to this patch?
Or can you point to what call in generic_handle_irq is making the
assumption that we are breaking?

Given this is using the irq_work framework I'm wondering if this is
a more general problem?

Basically more info please!

There is this series which causes generic_handle_irq() to issue an warning if it is called with IRQs on, for a IRQ controller that can't handle it.

But I'm not convinced this applies to the IIO code, since this is a purely virtual interrupt and is not interfering with any interrupt controller hardware.