Re: [PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications [ver #5]

From: Miklos Szeredi
Date: Mon Aug 03 2020 - 07:17:24 EST

On Mon, Aug 3, 2020 at 12:18 PM David Howells <dhowells@xxxxxxxxxx> wrote:
> Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> > > fsinfo() then allows you to retrieve them by path or by mount ID.
> >
> > Shouldn't the notification interface provide the unique ID?
> Hmmm... If I'm going to do that, I have to put the fsinfo-core branch first
> otherwise you can't actually retrieve the unique ID - and thus won't be able
> to make sense of the notification record. Such a rearrangement might make
> sense anyway since Ian and Karel have been primarily concentrating on fsinfo
> and only more recently started adding notification support.

OTOH mount notification is way smaller and IMO a more mature
interface. So just picking the unique ID patch into this set might
make sense.