Re: [PATCH v4 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

From: Jakub Kicinski
Date: Mon Aug 03 2020 - 16:29:54 EST

On Mon, 3 Aug 2020 20:34:48 +0200 pisa@xxxxxxxxxxxxxxxx wrote:
> From: Pavel Pisa <pisa@xxxxxxxxxxxxxxxx>
> This driver adds support for the CTU CAN FD open-source IP core.
> More documentation and core sources at project page
> (
> The core integration to Xilinx Zynq system as platform driver
> is available (
> Implementation on Intel FPGA based PCI Express board is available
> from project (
> The CTU CAN FD core emulation send for review for QEMU mainline.
> Development repository for QEMU emulation - ctu-canfd branch of
> More about CAN related projects used and developed at the Faculty
> of the Electrical Engineering (
> of Czech Technical University (
> in Prague at .

Patches 3 and 4 have warnings when built with W=1 C=1 flags.

Please also remove the uses of static inline in C sources.
Those are rarely necessary and hide unused code warnings.