Re: [PATCH v4 1/4] power: supply: core: add quick charge type property
From: Greg KH
Date: Tue Aug 04 2020 - 03:49:34 EST
On Tue, Aug 04, 2020 at 10:11:19AM +0800, ivan wrote:
> On Mon, Aug 3, 2020 at 7:57 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Aug 03, 2020 at 01:49:50PM +0200, Sebastian Reichel wrote:
> > > More importantely I prefer not to merge new APIs without any users
> > > (i.e. a driver making use of those values). Having a reference
> > > driver means, that there is an example how to use the values
> > > correctly and proves it is actually needed upstream. Right now
> > > this looks like "let's modify the upstream kernel, so that we can
> > > easily maintain our out of tree driver".
> > Agreed. Qiwu, can you also submit your driver so we can see these
> > values be used?
> Our driver is based on qualcomm's driver secondary development.
> The driver code is for mi 10.
> + case POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE:
> + val->intval = smblib_get_quick_charge_type(chg);
> + break;
Great, can you submit these drivers as patches as part of this series?
That's the best way for all of this to be integrated.