Re: False positive in checkpatch.pl
From: Joe Perches
Date: Tue Aug 04 2020 - 13:54:06 EST
On Tue, 2020-08-04 at 17:44 +0000, Kumar K, Anil wrote:
> Hi Joe,
Please always cc linux-kernel@xxxxxxxxxxxxxxx
> I noticed a false positive while executing checkpatch.pl. Checkpatch
> identifies the * as multiplication I guess. I saw there was some
> discussion about this before. Was there a workaround/fix for this ?
> Can u please share if so. Thanks for your time
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #8195: FILE: src/soc/intel/abc/include/soc/romstage.h:21:
> +void mainboard_memory_init_params(FSPM_UPD *mupd);
Basically, avoid typedefs.
Either have the typedef available for checkpatch in the same
file or don't use typedefs at all.
If your project has multiple typedefs and these messages
annoy you, you could add --typedefsfile=<filepath> to the
checkpatch command line where <filepath> contains a
one entry per line list of the typedefs used.