Re: [net v3] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

From: Xie He
Date: Tue Aug 04 2020 - 15:20:31 EST

On Tue, Aug 4, 2020 at 5:43 AM Martin Schiller <ms@xxxxxxxxxx> wrote:
> I'm not an expert in the field, but after reading the commit message and
> the previous comments, I'd say that makes sense.


> Shouldn't this kernel panic be intercepted by a skb_cow() before the
> skb_push() in lapbeth_data_transmit()?

When a skb is passing down a protocol stack for transmission, there
might be several different skb_push calls to prepend different
headers. It would be the best (in terms of performance) if we can
allocate the needed header space in advance, so that we don't need to
reallocate the skb every time a new header needs to be prepended.
Adding skb_cow before these skb_push calls would indeed help
preventing kernel panics, but that might not be the essential issue
here, and it might also prevent us from discovering the real issue. (I
guess this is also the reason skb_cow is not included in skb_push