Re: 答复: 答复: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR

From: Lu Baolu
Date: Tue Aug 04 2020 - 23:01:47 EST

Next message: kernel test robot: "drivers/video/fbdev/aty/mach64_cursor.c:156:13: sparse: sparse: incorrect type in argument 1 (different address spaces)"
Previous message: Bjorn Helgaas: "Re: [PATCH V2 1/9] pci_ids: Add class code and extended capability for RCEC"
In reply to: FelixCui-oc: "答复: 答复: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR"
Next in thread: FelixCui-oc: "答复: 答复: 答复: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

On 8/4/20 11:11 AM, FelixCui-oc wrote:

Hi baolu ,
When creating a identity mapping for a namespace device in RMRR, you need to add the namespace device to the rmrr->device[] , right?

Yes. You are right.

The dmar_acpi_bus_add_dev() in patch adds the enumeration of the namespace device in RMRR. This is similar to > enumerating pci devices. Do you think this is unreasonable? If it is

unreasonable, please tell me why it is unreasonable.

It looks reasonable. Thanks for the explanation.

But I don't think we need to add acpi_device_create_direct_mappings()
since the rmrr identity mapping is already done in the iommu core.

Best regards,
baolu

Best regards
Felix cui-oc

-----邮件原件-----
发件人: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
发送时间: 2020年8月4日 9:12
收件人: FelixCui-oc <FelixCui-oc@xxxxxxxxxxx>; Joerg Roedel <joro@xxxxxxxxxx>; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; David Woodhouse <dwmw2@xxxxxxxxxxxxx>
抄送: baolu.lu@xxxxxxxxxxxxxxx; RaymondPang-oc <RaymondPang-oc@xxxxxxxxxxx>; CobeChen-oc <CobeChen-oc@xxxxxxxxxxx>
主题: Re: 答复: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR

Hi Felix,

On 2020/8/3 17:41, FelixCui-oc wrote:

Hi baolu,
dmar_acpi_dev_scope_init() parse ANDD structure and enumerated namespaces device in DRHD.

Yes.

But the namespace device in RMRR is not enumerated, right?

It should be probed in probe_acpi_namespace_devices().

Best regards,
baolu

Best regards
Felix cui-oc

-----邮件原件-----
发件人: FelixCui-oc
发送时间: 2020年8月3日 17:02
收件人: 'Lu Baolu' <baolu.lu@xxxxxxxxxxxxxxx>; Joerg Roedel
<joro@xxxxxxxxxx>; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx; David Woodhouse <dwmw2@xxxxxxxxxxxxx>
抄送: RaymondPang-oc <RaymondPang-oc@xxxxxxxxxxx>; CobeChen-oc
<CobeChen-oc@xxxxxxxxxxx>
主题: 答复: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR

Hi baolu:
"The namespace devices are enumerated in probe_acpi_namespace_devices().
It calls iommu_probe_device() to process the enumeration and setup the identity mappings."

This situation only applies to the physical node of the namespaces device as the pci device.
In fact, the physical node of the namespaces device can be a platform device or NULL.
If the physical node of the namespaces is a platform device or NULL, it has not actually been enumerated.
So it is necessary to increase the analysis of the namespaces device in RMRR and establish an identity mapping.

Best regards
Felix cui

-----邮件原件-----
发件人: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
发送时间: 2020年8月3日 16:26
收件人: FelixCui-oc <FelixCui-oc@xxxxxxxxxxx>; Joerg Roedel
<joro@xxxxxxxxxx>; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx; David Woodhouse <dwmw2@xxxxxxxxxxxxx>
抄送: baolu.lu@xxxxxxxxxxxxxxx; RaymondPang-oc
<RaymondPang-oc@xxxxxxxxxxx>; CobeChen-oc <CobeChen-oc@xxxxxxxxxxx>
主题: Re: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR

On 2020/8/3 14:52, FelixCui-oc wrote:

Hi baolu ,
Yes ,that's right.
This patch is to achieve acpi namespace devices to access the RMRR region.

The namespace devices are enumerated in probe_acpi_namespace_devices().
It calls iommu_probe_device() to process the enumeration and setup the identity mappings. Can you please check why that code doesn't work for you?

Best regards,
baolu

Best regards
Felix cui

-----邮件原件-----
发件人: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
发送时间: 2020年8月3日 14:19
收件人: FelixCui-oc <FelixCui-oc@xxxxxxxxxxx>; Joerg Roedel
<joro@xxxxxxxxxx>; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx; David Woodhouse <dwmw2@xxxxxxxxxxxxx>
抄送: baolu.lu@xxxxxxxxxxxxxxx; RaymondPang-oc
<RaymondPang-oc@xxxxxxxxxxx>; CobeChen-oc <CobeChen-oc@xxxxxxxxxxx>
主题: Re: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR

Hi,

On 2020/8/3 12:40, FelixCui-oc wrote:

Hi baolu:
Some ACPI devices need to issue dma requests to access the reserved memory area.
So bios uses the device scope type ACPI_NAMESPACE_DEVICE in RMRR to report these ACPI devices.
At present, there is no analysis in the kernel that the device scope type in RMRR is ACPI_NAMESPACE_DEVICE.
This patch is mainly to add the analysis of the device scope type ACPI_NAMESPACE_DEVICE in RMRR structure and establish identity mapping for > these ACPI devices.

So the problem is "although namespace devices in RMRR have been parsed, but the identity map for those devices aren't created. As the result, the namespace devices fail to access the RMRR region."

Do I understand it right?

Best regards,
baolu

In addition, some naming changes have been made in patch in order to distinguish acpi device from pci device.
You can refer to the description of type in 8.3.1 device scope in vt-d spec.

Best regards
FelixCui-oc

-----邮件原件-----
发件人: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
发送时间: 2020年8月3日 10:32
收件人: FelixCui-oc <FelixCui-oc@xxxxxxxxxxx>; Joerg Roedel
<joro@xxxxxxxxxx>; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx; David Woodhouse <dwmw2@xxxxxxxxxxxxx>
抄送: baolu.lu@xxxxxxxxxxxxxxx; Cobe Chen(BJ-RD)
<CobeChen@xxxxxxxxxxx>; Raymond Pang(BJ-RD)
<RaymondPang@xxxxxxxxxxx>
主题: Re: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR

Hi,

On 8/2/20 6:07 PM, FelixCuioc wrote:

Some ACPI devices require access to the specified reserved memory
region.BIOS report the specified reserved memory region through
RMRR structures.Add analysis of ACPI device in RMRR and establish
identity mapping for ACPI device.

Can you please add more words about the problem you want to solve? Do you mean some RMRRs are not enumerated correctly? Or, enumerated, but not identity mapped?

Nit: add version and change log once you refreshed your patch.

Reported-by: kernel test robot <lkp@xxxxxxxxx>

No need to add this. The problem you want to solve through this patch is not reported by lkp.

Best regards,
baolu

Signed-off-by: FelixCuioc <FelixCui-oc@xxxxxxxxxxx>
---
drivers/iommu/intel/dmar.c | 74 ++++++++++++++++++++-----------------
drivers/iommu/intel/iommu.c | 46 ++++++++++++++++++++++-
drivers/iommu/iommu.c | 6 +++
include/linux/dmar.h | 12 +++++-
include/linux/iommu.h | 3 ++
5 files changed, 105 insertions(+), 36 deletions(-)

diff --git a/drivers/iommu/intel/dmar.c
b/drivers/iommu/intel/dmar.c index 93e6345f3414..024ca38dba12
100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -215,7 +215,7 @@ static bool dmar_match_pci_path(struct dmar_pci_notify_info *info, int bus,
}
/* Return: > 0 if match found, 0 if no match found, < 0 if
error happens */ -int dmar_insert_dev_scope(struct
dmar_pci_notify_info *info,
+int dmar_pci_insert_dev_scope(struct dmar_pci_notify_info *info,
void *start, void*end, u16 segment,
struct dmar_dev_scope *devices,
int devices_cnt)
@@ -304,7 +304,7 @@ static int dmar_pci_bus_add_dev(struct
dmar_pci_notify_info *info)
drhd = container_of(dmaru->hdr,
struct acpi_dmar_hardware_unit, header);
- ret = dmar_insert_dev_scope(info, (void *)(drhd + 1),
+ ret = dmar_pci_insert_dev_scope(info, (void *)(drhd + 1),
((void *)drhd) + drhd->header.length,
dmaru->segment,
dmaru->devices, dmaru->devices_cnt); @@ -696,48 +696,56 @@
dmar_find_matched_drhd_unit(struct pci_dev *dev)
return dmaru;
}
-
-static void __init dmar_acpi_insert_dev_scope(u8 device_number,
- struct acpi_device *adev)
+int dmar_acpi_insert_dev_scope(u8 device_number,
+ struct acpi_device *adev,
+ void *start, void *end,
+ struct dmar_dev_scope *devices,
+ int devices_cnt)
{
- struct dmar_drhd_unit *dmaru;
- struct acpi_dmar_hardware_unit *drhd;
struct acpi_dmar_device_scope *scope;
struct device *tmp;
int i;
struct acpi_dmar_pci_path *path;
+ for (; start < end; start += scope->length) {
+ scope = start;
+ if (scope->entry_type != ACPI_DMAR_SCOPE_TYPE_NAMESPACE)
+ continue;
+ if (scope->enumeration_id != device_number)
+ continue;
+ path = (void *)(scope + 1);
+ for_each_dev_scope(devices, devices_cnt, i, tmp)
+ if (tmp == NULL) {
+ devices[i].bus = scope->bus;
+ devices[i].devfn = PCI_DEVFN(path->device, path->function);
+ rcu_assign_pointer(devices[i].dev,
+ get_device(&adev->dev));
+ return 1;
+ }
+ WARN_ON(i >= devices_cnt);
+ }
+ return 0;
+}
+static int dmar_acpi_bus_add_dev(u8 device_number, struct
+acpi_device
+*adev) {
+ struct dmar_drhd_unit *dmaru;
+ struct acpi_dmar_hardware_unit *drhd;
+ int ret = 0;
+
for_each_drhd_unit(dmaru) {
drhd = container_of(dmaru->hdr,
struct acpi_dmar_hardware_unit,
header);
+ ret = dmar_acpi_insert_dev_scope(device_number, adev, (void *)(drhd+1),
+ ((void *)drhd)+drhd->header.length,
+ dmaru->devices, dmaru->devices_cnt);
+ if (ret)
+ break;
+ }
+ ret = dmar_rmrr_add_acpi_dev(device_number, adev);
- for (scope = (void *)(drhd + 1);
- (unsigned long)scope < ((unsigned long)drhd) + drhd->header.length;
- scope = ((void *)scope) + scope->length) {
- if (scope->entry_type != ACPI_DMAR_SCOPE_TYPE_NAMESPACE)
- continue;
- if (scope->enumeration_id != device_number)
- continue;
+ return ret;
- path = (void *)(scope + 1);
- pr_info("ACPI device \"%s\" under DMAR at %llx as %02x:%02x.%d\n",
- dev_name(&adev->dev), dmaru->reg_base_addr,
- scope->bus, path->device, path->function);
- for_each_dev_scope(dmaru->devices, dmaru->devices_cnt, i, tmp)
- if (tmp == NULL) {
- dmaru->devices[i].bus = scope->bus;
- dmaru->devices[i].devfn = PCI_DEVFN(path->device,
- path->function);
- rcu_assign_pointer(dmaru->devices[i].dev,
- get_device(&adev->dev));
- return;
- }
- BUG_ON(i >= dmaru->devices_cnt);
- }
- }
- pr_warn("No IOMMU scope found for ANDD enumeration ID %d (%s)\n",
- device_number, dev_name(&adev->dev));
}
static int __init dmar_acpi_dev_scope_init(void) @@ -766,7
+774,7 @@ static int __init dmar_acpi_dev_scope_init(void)
andd->device_name);
continue;
}
- dmar_acpi_insert_dev_scope(andd->device_number, adev);
+ dmar_acpi_bus_add_dev(andd->device_number, adev);
}
}
return 0;
diff --git a/drivers/iommu/intel/iommu.c
b/drivers/iommu/intel/iommu.c index ca557d351518..be1793415326
100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4507,6 +4507,24 @@ int dmar_find_matched_atsr_unit(struct
pci_dev
*dev)
return ret;
}
+int dmar_rmrr_add_acpi_dev(u8 device_number, struct acpi_device
+*adev) {
+ int ret;
+ struct dmar_rmrr_unit *rmrru;
+ struct acpi_dmar_reserved_memory *rmrr;
+
+ list_for_each_entry(rmrru, &dmar_rmrr_units, list) {
+ rmrr = container_of(rmrru->hdr,
+ struct acpi_dmar_reserved_memory,
+ header);
+ ret = dmar_acpi_insert_dev_scope(device_number, adev, (void *)(rmrr + 1),
+ ((void *)rmrr) + rmrr->header.length,
+ rmrru->devices, rmrru->devices_cnt);
+ if (ret)
+ break;
+ }
+ return 0;
+}
int dmar_iommu_notify_scope_dev(struct dmar_pci_notify_info *info)
{
@@ -4523,7 +4541,7 @@ int dmar_iommu_notify_scope_dev(struct dmar_pci_notify_info *info)
rmrr = container_of(rmrru->hdr,
struct acpi_dmar_reserved_memory, header);
if (info->event == BUS_NOTIFY_ADD_DEVICE) {
- ret = dmar_insert_dev_scope(info, (void *)(rmrr + 1),
+ ret = dmar_pci_insert_dev_scope(info, (void *)(rmrr + 1),
((void *)rmrr) + rmrr->header.length,
rmrr->segment, rmrru->devices,
rmrru->devices_cnt);
@@ -4541,7 +4559,7 @@ int dmar_iommu_notify_scope_dev(struct
dmar_pci_notify_info *info)
atsr = container_of(atsru->hdr, struct acpi_dmar_atsr, header);
if (info->event == BUS_NOTIFY_ADD_DEVICE) {
- ret = dmar_insert_dev_scope(info, (void *)(atsr + 1),
+ ret = dmar_pci_insert_dev_scope(info, (void *)(atsr + 1),
(void *)atsr + atsr->header.length,
atsr->segment, atsru->devices,
atsru->devices_cnt);
@@ -4779,6 +4797,26 @@ static int __init
platform_optin_force_iommu(void)
return 1;
}
+static int acpi_device_create_direct_mappings(struct device
+*pn_dev, struct device *acpi_device) {
+ int ret;
+ struct iommu_group *group;
+
+ if (pn_dev == NULL) {
+ acpi_device->bus->iommu_ops = &intel_iommu_ops;
+ ret = iommu_probe_device(acpi_device);
+ if (ret) {
+ pr_err("acpi_device probe fail! ret:%d\n", ret);
+ return ret;
+ }
+ return 0;
+ }
+ acpi_device->bus->iommu_ops = &intel_iommu_ops;
+ group = iommu_group_get(pn_dev);
+ __acpi_device_create_direct_mappings(group, acpi_device);
+
+ return 0;
+}
static int __init probe_acpi_namespace_devices(void)
{
@@ -4794,6 +4832,7 @@ static int __init probe_acpi_namespace_devices(void)
struct acpi_device_physical_node *pn;
struct iommu_group *group;
struct acpi_device *adev;
+ struct device *pn_dev = NULL;
if (dev->bus != &acpi_bus_type)
continue;
@@ -4804,6 +4843,7 @@ static int __init probe_acpi_namespace_devices(void)
&adev->physical_node_list, node) {
group = iommu_group_get(pn->dev);
if (group) {
+ pn_dev = pn->dev;
iommu_group_put(group);
continue;
}
@@ -4812,7 +4852,9 @@ static int __init probe_acpi_namespace_devices(void)
ret = iommu_probe_device(pn->dev);
if (ret)
break;
+ pn_dev = pn->dev;
}
+ ret = acpi_device_create_direct_mappings(pn_dev, dev);
mutex_unlock(&adev->physical_node_lock);
if (ret)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index
609bd25bf154..4f714a2d5ef7 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -779,6 +779,12 @@ static bool iommu_is_attach_deferred(struct iommu_domain *domain,
return false;
}
+void __acpi_device_create_direct_mappings(struct iommu_group
+*group, struct device *acpi_device) {
+ iommu_create_device_direct_mappings(group, acpi_device); }
+EXPORT_SYMBOL_GPL(__acpi_device_create_direct_mappings);
+
/**
* iommu_group_add_device - add a device to an iommu group
* @group: the group into which to add the device (reference
should be held) diff --git a/include/linux/dmar.h
b/include/linux/dmar.h index 65565820328a..881ac61a4336 100644
--- a/include/linux/dmar.h
+++ b/include/linux/dmar.h
@@ -113,10 +113,14 @@ extern int dmar_parse_dev_scope(void *start, void *end, int *cnt,
struct dmar_dev_scope **devices, u16 segment);
extern void *dmar_alloc_dev_scope(void *start, void *end, int *cnt);
extern void dmar_free_dev_scope(struct dmar_dev_scope
**devices, int *cnt); -extern int dmar_insert_dev_scope(struct
dmar_pci_notify_info *info,
+extern int dmar_pci_insert_dev_scope(struct dmar_pci_notify_info
+*info,
void *start, void*end, u16 segment,
struct dmar_dev_scope *devices,
int devices_cnt);
+extern int dmar_acpi_insert_dev_scope(u8 device_number,
+ struct acpi_device *adev, void *start, void *end,
+ struct dmar_dev_scope *devices, int devices_cnt);
+
extern int dmar_remove_dev_scope(struct dmar_pci_notify_info *info,
u16 segment, struct dmar_dev_scope *devices,
int count);
@@ -140,6 +144,7 @@ extern int dmar_parse_one_atsr(struct acpi_dmar_header *header, void *arg);
extern int dmar_check_one_atsr(struct acpi_dmar_header *hdr, void *arg);
extern int dmar_release_one_atsr(struct acpi_dmar_header *hdr, void *arg);
extern int dmar_iommu_hotplug(struct dmar_drhd_unit *dmaru,
bool insert);
+extern int dmar_rmrr_add_acpi_dev(u8 device_number, struct
+acpi_device *adev);
extern int dmar_iommu_notify_scope_dev(struct dmar_pci_notify_info *info);
#else /* !CONFIG_INTEL_IOMMU: */
static inline int intel_iommu_init(void) { return -ENODEV; }
@@
-150,6 +155,11 @@ static inline void intel_iommu_shutdown(void) { }
#define dmar_check_one_atsr dmar_res_noop
#define dmar_release_one_atsr dmar_res_noop
+static inline int dmar_rmrr_add_acpi_dev(u8 device_number, struct
+acpi_device *adev) {
+ return 0;
+}
+
static inline int dmar_iommu_notify_scope_dev(struct dmar_pci_notify_info *info)
{
return 0;
diff --git a/include/linux/iommu.h b/include/linux/iommu.h index
fee209efb756..9be134775886 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -514,6 +514,9 @@ extern void iommu_domain_window_disable(struct iommu_domain *domain, u32 wnd_nr)
extern int report_iommu_fault(struct iommu_domain *domain, struct device *dev,
unsigned long iova, int flags);
+extern void __acpi_device_create_direct_mappings(struct iommu_group *group,
+ struct device *acpi_device);
+
static inline void iommu_flush_tlb_all(struct iommu_domain *domain)
{
if (domain->ops->flush_iotlb_all)

Next message: kernel test robot: "drivers/video/fbdev/aty/mach64_cursor.c:156:13: sparse: sparse: incorrect type in argument 1 (different address spaces)"
Previous message: Bjorn Helgaas: "Re: [PATCH V2 1/9] pci_ids: Add class code and extended capability for RCEC"
In reply to: FelixCui-oc: "答复: 答复: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR"
Next in thread: FelixCui-oc: "答复: 答复: 答复: 答复: 答复: [PATCH] iommu/vt-d:Add support for ACPI device in RMRR"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]