[PATCHv4 0/4] EXC3000 Updates

From: Sebastian Reichel
Date: Wed Aug 05 2020 - 12:26:17 EST


This is PATCHv3 of the EXC80Hxx support patchset.

Changes since [PATCHv3]:
- reorder last two patches
- register 'fw_version' and 'model' sysfs files in i2c device's
sysfs node instead of input device
- Add Reviewed-by from Enric
- Add Rob Herring and DT mailinglist
- Drop probe_new API patch (applied)

Changes since [PATCHv2]:
- add #include <linux/size.h> for SZ_4K and SZ_16K (kbuild test bot)
- fw_version_show must be ssize_t (kbuild test bot)
- rename YAML binding file to include eeti, prefix (Enric)
- noise from gpio-reset patch (Enric)
- add comment for the retry loop (Enric, Martin)
- document sysfs entries (Enric)

Changes since [PATCHv1]:
- prepend new patch converting binding document to YAML
- prepend new patch switching to I2C probe_new
- append new patch adding reset-gpio support
- use explicit compatible values for the touchscreen chips instead of
a wildcast. Since the documentation, that I have is very vague let's
use different values for exc80h60 and exc80h84. This avoids wildcard
DT entries and means we are prepared when noticing differences
between the chips.
- add accidently removed terminator entry in exc3000_id
- use device structure with max_xy and name (suggested by Martin)
- use SZ_4K, SZ_16K defines (suggested by Dmitry)
- harden event check, so that MT1 and MT2 based chips only allow
their own event type.
- write more detailed commit description in the fw_version/model
sysfs patch to explain why the values are not cached and why
the simpler read(); sleep(); write() approach has not been used
- use DEVICE_ATTR_RO() in fw_version/model patch to improve readability
- fw_version/model: replace memcpy + null termination with strlcpy
- fw_version/model: increase buffer size for weird firmware versions
- fw_version/model: use sizeof() instead of hardcoded buffer sizes
- simplify exc3000_query_interrupt() by moving the complete() call to
the exc3000_interrupt().

I think I only ignored one review feedback, that the fw_version and
model sysfs nodes are attached to the input device instead of the
i2c device. This was done to avoid being racy:


Thanks in advance for looking at the patches,

-- Sebastian

[PATCHv3] https://lore.kernel.org/linux-input/20200520153936.46869-1-sebastian.reichel@xxxxxxxxxxxxx/
[PATCHv2] https://lore.kernel.org/linux-input/20200519182447.73405-1-sebastian.reichel@xxxxxxxxxxxxx/
[PATCHv1] https://lore.kernel.org/linux-input/20191107181010.17211-1-sebastian.reichel@xxxxxxxxxxxxx/

Sebastian Reichel (4):
dt-bindings: touchscreen: Convert EETI EXC3000 touchscreen to
Input: EXC3000: add EXC80H60 and EXC80H84 support
Input: EXC3000: Add reset gpio support
Input: EXC3000: Add support to query model and fw_version

.../ABI/testing/sysfs-driver-input-exc3000 | 15 ++
.../input/touchscreen/eeti,exc3000.yaml | 58 ++++
.../bindings/input/touchscreen/exc3000.txt | 26 --
drivers/input/touchscreen/exc3000.c | 249 +++++++++++++++++-
4 files changed, 308 insertions(+), 40 deletions(-)
create mode 100644 Documentation/ABI/testing/sysfs-driver-input-exc3000
create mode 100644 Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/exc3000.txt