Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

From: Linus Torvalds
Date: Wed Aug 05 2020 - 14:22:26 EST


On Wed, Aug 5, 2020 at 7:34 AM Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote:
>
> Is this something you're willing to merge directly please?

Done.

That said:

> -K: phylink
> +K: phylink\.h|struct\s+phylink|\.phylink|>phylink_|phylink_(autoneg|clear|connect|create|destroy|disconnect|ethtool|helper|mac|mii|of|set|start|stop|test|validate)

That's a very awkward pattern. I wonder if there could be better ways
to express this (ie "only apply this pattern to these files" kind of
thing)

Isn't the 'F' pattern already complete enough that maybe the K pattern
isn't even worth it?

Just a thought, no biggie.

Linus