Re: [PATCH] staging: Add Mediatek High Frequency Manager Framework
From: Greg Kroah-Hartman
Date: Thu Aug 06 2020 - 13:32:06 EST
On Thu, Aug 06, 2020 at 04:32:28PM +0800, hongxu.zhao wrote:
> On Tue, 2020-08-04 at 10:11 +0200, Greg Kroah-Hartman wrote:
> > On Tue, Aug 04, 2020 at 03:52:49PM +0800, hongxu.zhao wrote:
> > > Add a new sensor framework into linux kernel which can support multi client request sensor data.
> > > There are the following features:
> > > 1.Ringbuffer between manager and client;
> > > 2.Kernel space user interface;
> > > 3.User space user interface with syscall;
> > > 4.Each client hang detect mechanism;
> > > 5.Polling timer management in framework no need driver concern;
> > > 6.Polling kthread work intergrated into a single kthread
> > > worker to save system resources in framework no need driver concern;
> > > 7.Proc file system to show manager device and client details;
> > > 8.Compitable with android and widely used in many mediatek platform products;
> > >
> > > Change-Id: I6361cdc2d51de50f66eede7df099c4575e7ec473
> > Did you not run checkpatch.pl on this? :)
> > No need for change-id here.
> > But, most importantly, why is this in drivers/staging? What keeps it
> > from being in the "real" part of the kernel? I need a TODO file in the
> > directory of the driver listing what remains to be done and who is
> > responsible for doing this work and reviewing patches.
> > Can you resend this with that file added and the Change-id removed?
> > Also, why not just use the IIO interface, why are you creating
> > yet-another api for sensors? We already have 2, making a third seems
> > like something that guarantees this will never be mergable to the
> > correct part of the kernel.
> > And finally, /proc/ is not for devices, that is what sysfs is for,
> > please use that.
> I have modified checkpatch issue, but blocked by ARCH=alpha build error
> and I can't reproduce this build error in mediatek environment. I need
> spend some time setting up an environment to solve this problem and will
> send you the latest patch together after solving the problem of alpha
> build error.
If you can't easily fix the alpha issue, you can just mark the driver as
not able to be built there for now.
> Firstly I want keep it in the real part of kernel and I send mail to
> community to find the right maintainer, unfortunately, several emails
> were not answered.
Pointers to those emails on lore.kernel.org?
> Secondly I found iio upstream history it also started from staging at
> the beginning, maybe staging is the best start until it become mature we
> can move it to the real part of kernel.
iio started in staging, but now that the infrastructure is out of it,
there should not be any reason that new drivers be forced to go into
staging too. You only want to do it this way if for some reason you can
not get the work done on your own.
> Actually, we have already assessed IIO subsystem, but the conclusion is
> that it doesn't meet our requirement:
> 1. iio doesn't have sensor manager in kernel space.
What exactly do you mean by this? Who needs to be a "manager" here?
> 2. each driver under the iio subsystem needs to create workqueue or
> kthread by itself, waste system resources.
workqueues are very light, how many sensors and what type of resources
are you referring to here? And adding a whole new user api is not
exactly "tiny" either :)
> 3. iio doesn't have hang detect mechanism to detect polling thread hang.
That's userspace's issue, right?
> We need a sensor manager architecture in kernel space to select the best
> delay and latency that multi-client(user space or kernel space user)
> requested at the same time, and finally dispatch data to each client.
Why does that have to be in the kernel?
> We need lower resource comsumption, each driver can poll data by kthread
> work which intergrated into a single kthread worker to save system
> resources in framework.
Again, how many resources are you really saving here with a whole new
> We need detect polling thread hang to decide whether to send data to
Data to where?
> About proc, proc is only for High Frequency Manager Framework to show
> manager details and client details, is not for device drivers.
Then it is not needed :)
> we recommend device driver(like test/test_app.c) use sysfs which under
> High Frequency Manager Framework.
Then you need to document it really well as to what you are doing here.
But again, please try working with the IIO framework as that is what we
have today. Any improvements you make to it will help everyone out.
Adding a third way to handle sensor data to the kernel is probably not
going to work well for anyone...