Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci

From: Shuah Khan
Date: Thu Aug 06 2020 - 16:02:54 EST

On 8/6/20 1:57 PM, Greg Kroah-Hartman wrote:
On Thu, Aug 06, 2020 at 01:48:26PM -0600, Shuah Khan wrote:
On 6/22/20 10:14 AM, Shuah Khan wrote:
On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote:
On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote:
On 6/22/20 2:03 AM, Matthias Maennich wrote:
On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
On 6/4/20 1:31 PM, Julia Lawall wrote:

On Thu, 4 Jun 2020, Matthias Maennich wrote:

When running `make coccicheck` in report mode using the
add_namespace.cocci file, it will fail for files that contain
MODULE_LICENSE. Those match the replacement precondition, but spatch
errors out as virtual.ns is not set.

In order to fix that, add the virtual rule nsdeps and only
do search and
replace if that rule has been explicitly requested.

In order to make spatch happy in report mode, we also need a
dummy rule,
as otherwise it errors out with "No rules
apply". Using a script:python
rule appears unrelated and odd, but this is the shortest I
could come up

Adjust scripts/nsdeps accordingly to set the nsdeps rule
when run trough
`make nsdeps`.

Suggested-by: Julia Lawall <julia.lawall@xxxxxxxx>
Fixes: c7c4e29fb5a4 ("scripts: add_namespace:
Fix coccicheck failed")
Cc: YueHaibing <yuehaibing@xxxxxxxxxx>
Cc: jeyu@xxxxxxxxxx
Cc: cocci@xxxxxxxxxxxxxxx
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Matthias Maennich <maennich@xxxxxxxxxx>

Acked-by: Julia Lawall <julia.lawall@xxxxxxxx>

Shuah reported the problem to me, so you could add

Reported-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

Very cool. No errors with this patch. Thanks for fixing it

I am happy I could fix that and thanks for confirming. I assume your
Tested-by could be added?


Tested-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

Is somebody willing to take this patch through their tree?

My guess is that these go through kbuild git??

If you want to take this, that's fine with me.  But as I had the
original file come through my tree, I can take it too.  It's up to you,
either is ok with me.

Great. Please take this through your tree.

Greg! Looks like this one didn't make it in. Can you pick this up?

I think this is 55c7549819e4 ("scripts: add dummy report mode to
add_namespace.cocci") in Linus's tree right now, right?

Yes. It is in Linux 5.9. I was looking in the wrong place on
Linux 5.8. :(

-- Shuah