Re: [PATCH] clk: samsung: Prevent potential endless loop in the PLL set_rate ops
From: Chanwoo Choi
Date: Thu Aug 06 2020 - 21:20:49 EST
On 8/7/20 1:06 AM, Sylwester Nawrocki wrote:
> In the .set_rate callback for some PLLs there is a loop polling state
> of the PLL lock bit and it may become an endless loop when something
> goes wrong with the PLL. For some PLLs there is already (duplicated)
> code for polling with a timeout. This patch refactors that code a bit
> and moves it to a common helper function which is then used
> in .set_rate callbacks for all the PLLs.
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> drivers/clk/samsung/clk-pll.c | 94 +++++++++++++----------------------
> 1 file changed, 35 insertions(+), 59 deletions(-)
It fix the infinite loop and unify the duplicate code.
It looks good to me. Thanks.
Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>