Re: [PATCH 0/2] irqchip: irq-mt58xx: Add mt58xx series interrupt

From: Mark-PK Tsai
Date: Fri Aug 07 2020 - 08:52:16 EST


From: Marc Zyngier <maz@xxxxxxxxxx>

> On 2020-08-06 15:58, Daniel Palmer wrote:
> > Hi Mark-PK,
> >
> > On Thu, 6 Aug 2020 at 23:08, Mark-PK Tsai <mark-pk.tsai@xxxxxxxxxxxx>
> > wrote:
> >> > Do you know if it would be possible to confirm if they are
> >> > the
> >> > same thing? MediaTek bought MStar a few years ago so it seems likely
> >> > but I have no hard information.
> >> >
> >>
> >> Yes, it's for the same interrupt controller IP.
> >
> > That's good news. :)
> >
> >> > If they are the same thing could we work on making one series that
> >> > supports both use cases?
> >>
> >> Sure, and I think the irq controller driver should support both use
> >> cases.
> >> So how about keep the MTK version driver?
> >
> > I'm fine with that. Maybe you can push the MTK version and I can send
> > a small patch after that to add the small bits I need?
>
> In the interest of being vendor agnostic, please rename the properties
> such as mediatek,irqs-map-range to something less brand-specific.
> The compatible string should be enough.

I can't find the suitable property in standard ones that match the custom
properties here.
And the vendor prefixed rule is described in [1].

The interrupt controller is first used in Mstar TV SoCs.
Now it's used in MTK TV and Sigmastar SoCs.
So I think Mstar prefixed would make more sense.
I will rename the driver into mstar-intc, and MTK will maintain this driver.

[1] https://www.kernel.org/doc/Documentation/devicetree/booting-without-of.txt