Re: [PATCH v2] hwmon/pmbus: use simple i2c probe function
From: Guenter Roeck
Date: Fri Aug 07 2020 - 11:23:35 EST
On 8/7/20 12:45 AM, Stephen Kitt wrote:
> pmbus_do_probe doesn't use the id information provided in its second
> argument, so this can be removed, which then allows using the
> single-parameter i2c probe function ("probe_new") for probes.
> This avoids scanning the identifier tables during probes.
> Drivers which didn't use the id are converted as-is; drivers which did
> are modified as follows:
> * if the information in i2c_client is sufficient, that's used instead
> * configured v. probed comparisons are performed by comparing the
> configured name to the detected name, instead of the ids; this
> involves strcmp but is still cheaper than comparing all the device
> names when scanning the tables;
> * anything else is handled by calling i2c_match_id() with the same
> level of error-handling (if any) as before.
> Signed-off-by: Stephen Kitt <steve@xxxxxxx>
Please also update the documentation.
Documentation/hwmon/pmbus-core.rst: int pmbus_do_probe(struct i2c_client *client, const struct i2c_device_id *id,
Documentation/hwmon/pmbus.rst: return pmbus_do_probe(client, id, &ds1200_info);
Also, please fix the checkpatch issue reported by Wolfram.