Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

From: Randy Dunlap
Date: Fri Aug 07 2020 - 11:27:49 EST


On 8/7/20 12:17 AM, Tanmay Shah wrote:
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index ea3c4d094d09..cc1392b29022 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP
> config DRM_MSM_DP
> bool "Enable DP support in MSM DRM driver"
> depends on DRM_MSM
> + default y
> help
> Compile in support for DP driver in msm drm driver. DP external
> display support is enabled through this config option. It can

Hi,

You need a very strong justification to make an optional part of a driver
to be "default y".

so why?

thanks.
--
~Randy