Re: [PATCH] lib: Convert test_hexdump.c to KUnit
From: David Gow
Date: Fri Aug 07 2020 - 17:33:25 EST
On Thu, Aug 6, 2020 at 5:53 PM Andy Shevchenko
> On Thu, Aug 6, 2020 at 12:48 PM Arpitha Raghunandan <98.arpi@xxxxxxxxx> wrote:
> > Converts test lib/test_hexdump.c to KUnit.
> > More information about KUnit can be found at
> > https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html.
> > KUnit provides a common framework for unit tests in the kernel.
> > -config TEST_HEXDUMP
> > - tristate "Test functions located in the hexdump module at runtime"
> We have a nice collection of tests starting with TEST_ in the
> configuration, now it's gone.
> I'm strongly against this change.
> Code itself okay, but without addressing above - NAK.
This change is to make the test naming compliant with the proposed
KUnit test naming guidelines:
The hope is that tests built on KUnit will all end up with the same
[x]_KUNIT_TEST config options (which at least preserves the
consistency of the test naming, even if they'll not all sort
together), and should make it easier for people to know that the test
results will be in a common format, and that the test can also be run
using the KUnit tools.
The naming guidelines haven't been upstreamed yet, though, so we'd
definitely appreciate input on that thread if you've got comments more
broadly than for this particular patch. Ultimately, I don't think it
matters too much what we end up using, but having some consistency is