Re: [PATCH 3/7] dyndbg: select ZPOOL in Kconfig.debug

From: Randy Dunlap
Date: Sun Aug 09 2020 - 01:15:19 EST


On 8/7/20 1:09 PM, Jim Cromie wrote:
> dyndbg will next need zs_malloc and friends, so add config reqs now,
> to avoid touching make-deps late in a patch-set.
>
> I used select in order not to hide dyndbg inadvertently.
> I want to say recommends, since it could be an optional feature.
> Whats the best way ?

Hi Jim,
Can you elaborate on what/why/when it could be an optional feature?

>
> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 9ad9210d70a1..a7973063baf0 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -100,6 +100,7 @@ config DYNAMIC_DEBUG
> depends on PRINTK
> depends on (DEBUG_FS || PROC_FS)
> select DYNAMIC_DEBUG_CORE
> + select ZPOOL
> help
>
> Compiles debug level messages into the kernel, which would not
>


--
~Randy