Re: [PATCH v3 3/7] x86/xen: drop tests for highmem in pv code

[Jürgen Groß]

On 09.08.20 04:22, Boris Ostrovsky wrote:
> On 8/7/20 4:38 AM, Juergen Gross wrote:
> > With support for 32-bit pv guests gone pure pv-code no longer needs to
> > test for highmem. Dropping those tests removes the need for flushing
> > in some places.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>
>
> with a suggestion
>
>
> > ---
> >   arch/x86/xen/enlighten_pv.c |  11 ++-
> >   arch/x86/xen/mmu_pv.c       | 138 ++++++++++++++----------------------
> >   2 files changed, 57 insertions(+), 92 deletions(-)
> >
> > diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> > index 7d90b3da8bb4..9fec952f84f3 100644
> > --- a/arch/x86/xen/enlighten_pv.c
> > +++ b/arch/x86/xen/enlighten_pv.c
> > @@ -347,6 +347,7 @@ static void set_aliased_prot(void *v, pgprot_t prot)
> >   	unsigned long pfn;
> >   	struct page *page;
> >   	unsigned char dummy;
> > +	void *av;
>
>
> to rename this to va since you are modifying those lines anyway.

Yes.


Juergen