RE: [PATCH v3 0/3] clk: zynqmp: Add firmware specific clock flags

From: Amit Sunil Dhamne
Date: Mon Aug 10 2020 - 18:06:19 EST


Hi Stephen, Reviewers,
I wanted to gently follow up on the review of this patch.

Thanks,
Amit

> -----Original Message-----
> From: Amit Sunil Dhamne <amit.sunil.dhamne@xxxxxxxxxx>
> Sent: Monday, August 3, 2020 11:44 PM
> To: mturquette@xxxxxxxxxxxx; m.tretter@xxxxxxxxxxxxxx;
> sboyd@xxxxxxxxxx; Michal Simek <michals@xxxxxxxxxx>;
> mark.rutland@xxxxxxx; linux-clk@xxxxxxxxxxxxxxx
> Cc: Rajan Vaja <RAJANV@xxxxxxxxxx>; Jolly Shah <JOLLYS@xxxxxxxxxx>; Tejas
> Patel <TEJASP@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Amit Sunil Dhamne <amitsuni@xxxxxxxxxx>
> Subject: [PATCH v3 0/3] clk: zynqmp: Add firmware specific clock flags
>
> Currently firmware is maintaining CCF specific flags and provides to CCF as it
> is. But CCF flag numbers may change and that shouldn't mean that the
> firmware needs to change. The firmware should have its own 'flag number
> space' that is distinct from the common clk framework's 'flag number space'.
> So use firmware specific clock flags in ZynqMP clock driver instead of CCF
> flags.
>
> Changes in v3:
> - Modify helper function signature to map zynqmp (common)flags with CCF
> - Add helper function to map zynqmp (mux & divider)flags with CCF flags
>
> Changes in v2:
> - Add helper function to map zynqmp (common)flags with CCF flags.
> - Mapped zynqmp clock flags with CCF flags from
> zynqmp_clk_register_*() functions instead of
> __zynqmp_clock_get_topology() which is changing the flags to struct
> clk_init_data instead of the struct clock_topology.
>
> Rajan Vaja (3):
> clk: zynqmp: Use firmware specific common clock flags
> clk: zynqmp: Use firmware specific divider clock flags
> clk: zynqmp: Use firmware specific mux clock flags
>
> drivers/clk/zynqmp/clk-gate-zynqmp.c | 4 +++- drivers/clk/zynqmp/clk-
> mux-zynqmp.c | 26 +++++++++++++++++++++--
> drivers/clk/zynqmp/clk-zynqmp.h | 41
> ++++++++++++++++++++++++++++++++++++
> drivers/clk/zynqmp/clkc.c | 32 +++++++++++++++++++++++++++-
> drivers/clk/zynqmp/divider.c | 29 ++++++++++++++++++++++---
> drivers/clk/zynqmp/pll.c | 4 +++-
> 6 files changed, 128 insertions(+), 8 deletions(-)
>
> --
> 2.7.4