KMSAN: uninit-value in hsr_addr_subst_dest

From: syzbot
Date: Thu Aug 13 2020 - 12:08:28 EST


Hello,

syzbot found the following issue on:

HEAD commit: ce8056d1 wip: changed copy_from_user where instrumented
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=14680fd6900000
kernel config: https://syzkaller.appspot.com/x/.config?x=3afe005fb99591f
dashboard link: https://syzkaller.appspot.com/bug?extid=586193f55faeec53d3e3
compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
userspace arch: i386

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+586193f55faeec53d3e3@xxxxxxxxxxxxxxxxxxxxxxxxx

=====================================================
BUG: KMSAN: uninit-value in hsr_addr_subst_dest+0x4f7/0x760 net/hsr/hsr_framereg.c:315
CPU: 1 PID: 15547 Comm: syz-executor.3 Not tainted 5.8.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x21c/0x280 lib/dump_stack.c:118
kmsan_report+0xf7/0x1e0 mm/kmsan/kmsan_report.c:121
__msan_warning+0x58/0xa0 mm/kmsan/kmsan_instr.c:215
hsr_addr_subst_dest+0x4f7/0x760 net/hsr/hsr_framereg.c:315
hsr_xmit net/hsr/hsr_forward.c:221 [inline]
hsr_forward_do net/hsr/hsr_forward.c:285 [inline]
hsr_forward_skb+0x22a2/0x3600 net/hsr/hsr_forward.c:361
hsr_dev_xmit+0x133/0x230 net/hsr/hsr_device.c:221
__netdev_start_xmit include/linux/netdevice.h:4611 [inline]
netdev_start_xmit include/linux/netdevice.h:4625 [inline]
xmit_one+0x3cf/0x750 net/core/dev.c:3556
dev_hard_start_xmit net/core/dev.c:3572 [inline]
__dev_queue_xmit+0x3aad/0x4470 net/core/dev.c:4131
dev_queue_xmit+0x4b/0x60 net/core/dev.c:4164
__bpf_tx_skb net/core/filter.c:2086 [inline]
__bpf_redirect_common net/core/filter.c:2125 [inline]
__bpf_redirect+0x1479/0x16b0 net/core/filter.c:2132
____bpf_clone_redirect net/core/filter.c:2165 [inline]
bpf_clone_redirect+0x498/0x650 net/core/filter.c:2137
___bpf_prog_run+0x4498/0x98e0 kernel/bpf/core.c:1516
__bpf_prog_run512+0x12e/0x190 kernel/bpf/core.c:1694
bpf_test_run+0x52d/0xed0 include/linux/filter.h:734
bpf_prog_test_run_skb+0x1053/0x2ad0 net/bpf/test_run.c:459
bpf_prog_test_run kernel/bpf/syscall.c:2983 [inline]
__do_sys_bpf+0xb364/0x1a4c0 kernel/bpf/syscall.c:4135
__se_sys_bpf+0x8e/0xa0 kernel/bpf/syscall.c:4075
__ia32_sys_bpf+0x4a/0x70 kernel/bpf/syscall.c:4075
do_syscall_32_irqs_on arch/x86/entry/common.c:430 [inline]
__do_fast_syscall_32+0x2af/0x480 arch/x86/entry/common.c:477
do_fast_syscall_32+0x6b/0xd0 arch/x86/entry/common.c:505
do_SYSENTER_32+0x73/0x90 arch/x86/entry/common.c:554
entry_SYSENTER_compat_after_hwframe+0x4d/0x5c
RIP: 0023:0xf7f0c549
Code: Bad RIP value.
RSP: 002b:00000000f55060cc EFLAGS: 00000296 ORIG_RAX: 0000000000000165
RAX: ffffffffffffffda RBX: 000000000000000a RCX: 0000000020000740
RDX: 0000000000000028 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000

Uninit was stored to memory at:
kmsan_save_stack_with_flags mm/kmsan/kmsan.c:144 [inline]
kmsan_internal_chain_origin+0xad/0x130 mm/kmsan/kmsan.c:310
kmsan_memcpy_memmove_metadata+0x272/0x2e0 mm/kmsan/kmsan.c:247
kmsan_memmove_metadata+0xe/0x10 mm/kmsan/kmsan.c:272
__msan_memmove+0x43/0x50 mm/kmsan/kmsan_instr.c:92
create_tagged_skb net/hsr/hsr_forward.c:172 [inline]
frame_get_tagged_skb net/hsr/hsr_forward.c:194 [inline]
hsr_forward_do net/hsr/hsr_forward.c:273 [inline]
hsr_forward_skb+0x2ae1/0x3600 net/hsr/hsr_forward.c:361
hsr_dev_xmit+0x133/0x230 net/hsr/hsr_device.c:221
__netdev_start_xmit include/linux/netdevice.h:4611 [inline]
netdev_start_xmit include/linux/netdevice.h:4625 [inline]
xmit_one+0x3cf/0x750 net/core/dev.c:3556
dev_hard_start_xmit net/core/dev.c:3572 [inline]
__dev_queue_xmit+0x3aad/0x4470 net/core/dev.c:4131
dev_queue_xmit+0x4b/0x60 net/core/dev.c:4164
__bpf_tx_skb net/core/filter.c:2086 [inline]
__bpf_redirect_common net/core/filter.c:2125 [inline]
__bpf_redirect+0x1479/0x16b0 net/core/filter.c:2132
____bpf_clone_redirect net/core/filter.c:2165 [inline]
bpf_clone_redirect+0x498/0x650 net/core/filter.c:2137
___bpf_prog_run+0x4498/0x98e0 kernel/bpf/core.c:1516
__bpf_prog_run512+0x12e/0x190 kernel/bpf/core.c:1694
bpf_test_run+0x52d/0xed0 include/linux/filter.h:734
bpf_prog_test_run_skb+0x1053/0x2ad0 net/bpf/test_run.c:459
bpf_prog_test_run kernel/bpf/syscall.c:2983 [inline]
__do_sys_bpf+0xb364/0x1a4c0 kernel/bpf/syscall.c:4135
__se_sys_bpf+0x8e/0xa0 kernel/bpf/syscall.c:4075
__ia32_sys_bpf+0x4a/0x70 kernel/bpf/syscall.c:4075
do_syscall_32_irqs_on arch/x86/entry/common.c:430 [inline]
__do_fast_syscall_32+0x2af/0x480 arch/x86/entry/common.c:477
do_fast_syscall_32+0x6b/0xd0 arch/x86/entry/common.c:505
do_SYSENTER_32+0x73/0x90 arch/x86/entry/common.c:554
entry_SYSENTER_compat_after_hwframe+0x4d/0x5c

Uninit was created at:
kmsan_save_stack_with_flags mm/kmsan/kmsan.c:144 [inline]
kmsan_internal_poison_shadow+0x66/0xd0 mm/kmsan/kmsan.c:127
kmsan_slab_alloc+0x8a/0xe0 mm/kmsan/kmsan_hooks.c:80
slab_alloc_node mm/slub.c:2839 [inline]
__kmalloc_node_track_caller+0xeab/0x12e0 mm/slub.c:4478
__kmalloc_reserve net/core/skbuff.c:142 [inline]
__alloc_skb+0x35f/0xb30 net/core/skbuff.c:210
__pskb_copy_fclone+0x173/0x1940 net/core/skbuff.c:1552
__pskb_copy include/linux/skbuff.h:1147 [inline]
create_tagged_skb net/hsr/hsr_forward.c:158 [inline]
frame_get_tagged_skb net/hsr/hsr_forward.c:194 [inline]
hsr_forward_do net/hsr/hsr_forward.c:273 [inline]
hsr_forward_skb+0x1ee8/0x3600 net/hsr/hsr_forward.c:361
hsr_dev_xmit+0x133/0x230 net/hsr/hsr_device.c:221
__netdev_start_xmit include/linux/netdevice.h:4611 [inline]
netdev_start_xmit include/linux/netdevice.h:4625 [inline]
xmit_one+0x3cf/0x750 net/core/dev.c:3556
dev_hard_start_xmit net/core/dev.c:3572 [inline]
__dev_queue_xmit+0x3aad/0x4470 net/core/dev.c:4131
dev_queue_xmit+0x4b/0x60 net/core/dev.c:4164
__bpf_tx_skb net/core/filter.c:2086 [inline]
__bpf_redirect_common net/core/filter.c:2125 [inline]
__bpf_redirect+0x1479/0x16b0 net/core/filter.c:2132
____bpf_clone_redirect net/core/filter.c:2165 [inline]
bpf_clone_redirect+0x498/0x650 net/core/filter.c:2137
___bpf_prog_run+0x4498/0x98e0 kernel/bpf/core.c:1516
__bpf_prog_run512+0x12e/0x190 kernel/bpf/core.c:1694
bpf_test_run+0x52d/0xed0 include/linux/filter.h:734
bpf_prog_test_run_skb+0x1053/0x2ad0 net/bpf/test_run.c:459
bpf_prog_test_run kernel/bpf/syscall.c:2983 [inline]
__do_sys_bpf+0xb364/0x1a4c0 kernel/bpf/syscall.c:4135
__se_sys_bpf+0x8e/0xa0 kernel/bpf/syscall.c:4075
__ia32_sys_bpf+0x4a/0x70 kernel/bpf/syscall.c:4075
do_syscall_32_irqs_on arch/x86/entry/common.c:430 [inline]
__do_fast_syscall_32+0x2af/0x480 arch/x86/entry/common.c:477
do_fast_syscall_32+0x6b/0xd0 arch/x86/entry/common.c:505
do_SYSENTER_32+0x73/0x90 arch/x86/entry/common.c:554
entry_SYSENTER_compat_after_hwframe+0x4d/0x5c
=====================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@xxxxxxxxxxxxxxxx.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.