Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

From: Kalle Valo
Date: Fri Aug 14 2020 - 13:25:59 EST


Lee Jones <lee.jones@xxxxxxxxxx> writes:

> On Fri, 14 Aug 2020, Kalle Valo wrote:
>
>> Lee Jones <lee.jones@xxxxxxxxxx> writes:
>>
>> > Fixes the following W=1 kernel build warning(s):
>> >
>> > drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_dummy_transmission’:
>> > drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest
>> > braces around empty body in an ‘if’ statement [-Wempty-body]
>> > drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_do_interrupt_thread’:
>> > drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest
>> > braces around empty body in an ‘if’ statement [-Wempty-body]
>> >
>> > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
>> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
>> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
>> > Cc: Martin Langer <martin-langer@xxxxxx>
>> > Cc: Stefano Brivio <stefano.brivio@xxxxxxxxx>
>> > Cc: Michael Buesch <m@xxxxxxx>
>> > Cc: van Dyk <kugelfang@xxxxxxxxxx>
>> > Cc: Andreas Jaggi <andreas.jaggi@xxxxxxxxxxxx>
>> > Cc: Albert Herranz <albert_herranz@xxxxxxxx>
>> > Cc: linux-wireless@xxxxxxxxxxxxxxx
>> > Cc: b43-dev@xxxxxxxxxxxxxxxxxxx
>> > Cc: netdev@xxxxxxxxxxxxxxx
>> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>> > ---
>> > drivers/net/wireless/broadcom/b43/main.c | 6 ++++--
>> > 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> Please don't copy the full directory structure to the title. I'll change
>> the title to more simple version:
>>
>> b43: add braces around empty statements
>
> This seems to go the other way.
>
> "net: wireless: b43" seems sensible.

Sorry, not understanding what you mean here.

>> I'll do similar changes to other wireless-drivers patches.
>
> Thanks.
>
> Does that mean it's been applied, or is this future tense?

It's not applied yet, there will be an automatic "applied" email once I
have done that.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches