Re: [PATCH] net: handle the return value of pskb_carve_frag_list() correctly

From: David Miller
Date: Sun Aug 16 2020 - 19:01:28 EST


From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Date: Sat, 15 Aug 2020 04:46:41 -0400

> + /* split line is in frag list */
> + if (k == 0 && pskb_carve_frag_list(skb, shinfo, off - pos, gfp_mask)) {
> + /* skb_frag_unref() is not needed here as shinfo->nr_frags = 0. */
> + if (skb_has_frag_list(skb))
> + kfree_skb_list(skb_shinfo(skb)->frag_list);
> + kfree(data);
> + return -ENOMEM;

On error, the caller is going to kfree_skb(skb) which will take care of the
frag list.