Re: [Linux-kernel-mentees] [PATCH v2 RESEND] usbhid: Fix slab-out-of-bounds write in hiddev_ioctl_usage()

From: Jiri Kosina
Date: Mon Aug 17 2020 - 06:21:46 EST


On Wed, 29 Jul 2020, Peilin Ye wrote:

> `uref->usage_index` is not always being properly checked, causing
> hiddev_ioctl_usage() to go out of bounds under some cases. Fix it.
>
> Reported-by: syzbot+34ee1b45d88571c2fa8b@xxxxxxxxxxxxxxxxxxxxxxxxx
> Link: https://syzkaller.appspot.com/bug?id=f2aebe90b8c56806b050a20b36f51ed6acabe802
> Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Peilin Ye <yepeilin.cs@xxxxxxxxx>
> ---
> Change in v2:
> - Add the same check for the `HIDIOCGUSAGE` case. (Suggested by
> Dan Carpenter <dan.carpenter@xxxxxxxxxx>)

Applied, thanks.

--
Jiri Kosina
SUSE Labs