RE: [PATCH 0/3] ASoC: da7219: Reorganise device/codec level probe/remove

From: Zhi, Yong
Date: Tue Aug 18 2020 - 12:39:09 EST


Hi, Adam,

> -----Original Message-----
> From: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> Sent: Tuesday, August 11, 2020 11:57 AM
> To: Mark Brown <broonie@xxxxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Liam
> Girdwood <lgirdwood@xxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Zhi, Yong <yong.zhi@xxxxxxxxx>; Pierre-Louis Bossart <pierre-
> louis.bossart@xxxxxxxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Support Opensource
> <support.opensource@xxxxxxxxxxx>
> Subject: [PATCH 0/3] ASoC: da7219: Reorganise device/codec level
> probe/remove
>
> This patch set reorganises and fixes device and codec level probe/remove
> handling within the driver, to allow clean probe and remove at the codec level.
>
> This set relates to an issue raised by Yong Zhi where a codec level re-probe
> would fail due to clks still being registered from the previous instantiation.
> In addition some improvements around regulator handling and soft reset have
> also been included.
>

Just to let you know that I tested this series on the JSL platform, the original issue was resolved, also sanity checked basic use case like plug/unplug and
suspend/resume, no regression found.

thanks,
yong
> Adam Thomson (3):
> ASoC: da7219: Move required devm_* allocations to device level code
> ASoC: da7219: Move soft reset handling to codec level probe
> ASoC: da7219: Fix clock handling around codec level probe
>
> sound/soc/codecs/da7219-aad.c | 85 +++++---
> sound/soc/codecs/da7219-aad.h | 3 +
> sound/soc/codecs/da7219.c | 493 +++++++++++++++++++++++-----------------
> --
> sound/soc/codecs/da7219.h | 1 +
> 4 files changed, 328 insertions(+), 254 deletions(-)
>
> --
> 1.9.1