Re: [PATCH] MAINTAINERS: Add entries for CoreSight and Arm SPE

[Leo Yan]

On Tue, Aug 18, 2020 at 06:54:28PM +0100, John Garry wrote:
> On 17/08/2020 20:31, Mathieu Poirier wrote:
> > Add entries for perf tools elements related to the support of
> > Arm CoreSight and Arm SPE.
> 
> Thanks for doing this...
> 
> > 
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> > ---
> >   MAINTAINERS | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4e2698cc7e23..f9bb76baeec9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13427,8 +13427,18 @@ F:	tools/perf/
> >   PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> >   R:	John Garry <john.garry@xxxxxxxxxx>
> >   R:	Will Deacon <will@xxxxxxxxxx>
> > +R:	Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> > +R:	Leo Yan <leo.yan@xxxxxxxxxx>
> >   L:	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> >   S:	Supported
> > +F:	tools/build/feature/test-libopencsd.c
> > +F:	tools/perf/arch/arm/util/auxtrace.c
> > +F:	tools/perf/arch/arm/util/cs-etm.*
> > +F:	tools/perf/arch/arm/util/pmu.c
> > +F:	tools/perf/arch/arm64/util/arm-spe.c
> > +F:	tools/perf/util/arm-spe.h
> > +F:	tools/perf/util/cs-etm-decoder/*
> > +F:	tools/perf/util/cs-etm.*
> 
> But from the previous discussion, I thought that we wanted an entry to cover
> all tools/perf/arch/arm64/ and other related folders. Or was it just put all
> special interest parts (like SPE support) under one entry and leave the
> other arm/arm64 parts to be caught by "PERFORMANCE EVENTS SUBSYSTEM" entry?

Yes, I think we need to add below two items for Arm SPE:

F:	tools/perf/util/arm-spe-decoder/*
F:	tools/perf/util/arm-spe.*

Thanks,
Leo

> >   F:	tools/perf/pmu-events/arch/arm64/
> >   PERSONALITY HANDLING
> > 
>