RE: [PATCH v3] usb-serial:cp210x: add support to software flow control

From: Wang, Sheng Long
Date: Mon Aug 24 2020 - 06:16:22 EST


Hi, Johan

So, Is it currently possible for me to use which Branch? :)

https://github.com/torvalds/linux master branch

Or use https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git

Thanks!
BR/Sheng Long

-----Original Message-----
From: Johan Hovold <johan@xxxxxxxxxx>
Sent: Monday, August 24, 2020 5:43 PM
To: Kiszka, Jan (CT RDA IOT SES-DE) <jan.kiszka@xxxxxxxxxxx>
Cc: Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) <shenglong.wang.ext@xxxxxxxxxxx>; Johan Hovold <johan@xxxxxxxxxx>; Sheng Long Wang <china_shenglong@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software flow control

On Mon, Aug 24, 2020 at 11:36:50AM +0200, Jan Kiszka wrote:
> On 24.08.20 11:28, Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) wrote:
> > Hi Johan,
> >
> > Thanks for your reminding. I am adjusting patch according to the latest Linux Master branch.
>
> Use git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git,
> branch is likely usb-linus, as Johan requested - just in case there is
> another conflict due to a patch not yet in Linux master but in that tree.

The usb-next is used for new features like this one, but again, currently Linus's master branch works as well.

> > -----Original Message-----
> > From: Johan Hovold <johan@xxxxxxxxxx>
> > Sent: Monday, August 24, 2020 5:10 PM
> > To: Kiszka, Jan (CT RDA IOT SES-DE) <jan.kiszka@xxxxxxxxxxx>
> > Cc: Sheng Long Wang <china_shenglong@xxxxxxx>; Wang, Sheng Long
> > (EXT) (RC-CN DI FA R&D SW) <shenglong.wang.ext@xxxxxxxxxxx>;
> > johan@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
> > linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software
> > flow control
> >
> > On Fri, Aug 21, 2020 at 07:32:58AM +0200, Jan Kiszka wrote:
> >> On 20.08.20 09:52, Sheng Long Wang wrote:
> >>> From: Wang Sheng Long <shenglong.wang.ext@xxxxxxxxxxx>
> >>>
> >>> When data is transmitted between two serial ports, the phenomenon
> >>> of data loss often occurs. The two kinds of flow control commonly
> >>> used in serial communication are hardware flow control and
> >>> software flow control.
> >>>
> >>> In serial communication, If you only use RX/TX/GND Pins, you can't
> >>> do hardware flow. So we often used software flow control and
> >>> prevent data loss. The user sets the software flow control through
> >>> the application program, and the application program sets the
> >>> software flow control mode for the serial port chip through the driver.
> >>>
> >>> For the cp210 serial port chip, its driver lacks the software flow
> >>> control setting code, so the user cannot set the software flow
> >>> control function through the application program. This adds the
> >>> missing software flow control.
> >>>
> >>> Signed-off-by: Wang Sheng Long <shenglong.wang.ext@xxxxxxxxxxx>
> >>>
> >>> Changes in v3:
> >>> -fixed code style, It mainly adjusts the code style acccording to
> >>> kernel specification.
> >>
> >> Patch does not apply. You forgot to rebase over latest tty/tty-next
> >> or linux master.
> >
> > That should be the usb-next branch of the usb-serial tree:
> >
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
> > /
> >
> > or linux-next (or, currently, Linus's master branch).
> >
> > You can use "scripts/get_maintainer.sh --scm" to determine which tree to base your work against.
>
> Thanks for correcting! But it's scripts/get_maintainer.pl. ;)

Heh. Thanks for catching that.

Johan