Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support

From: Mark Brown
Date: Mon Aug 24 2020 - 07:25:50 EST


On Sat, Aug 22, 2020 at 06:21:18PM +0300, Vladimir Oltean wrote:
> On Sat, Aug 22, 2020 at 07:37:25PM +0530, Kuldip Dwivedi wrote:

> > > The whole point with the device property API is that it works with
> > > both DT and ACPI without needing separate parsing, though in this
> > > case I'm wondering why we'd need to specify this in an ACPI system
> > > at all?

> > Understood. Will take care in v2 PATCH

> IMO there is zero reason for the existence of the "spi-num-chipselects"
> property even for DT. We should deprecate it (start ignoring it in
> existing device tree deployments) and populate struct
> fsl_dspi_devtype_data with that info based on SoC compatible string.

Yes, it's a legacy from bad board file conversions and shouldn't be used
at all.

Attachment: signature.asc
Description: PGP signature