Re: [PATCH] dma-buf: heaps: Introduce dma_heap_add_cma() for non-default CMA heap

[Kunihiko Hayashi]

Hi John,

On 2020/08/22 3:32, John Stultz wrote:
> On Fri, Aug 21, 2020 at 2:14 AM Kunihiko Hayashi
> <hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
> > On 2020/08/01 4:38, John Stultz wrote:
> > > On Fri, Jul 31, 2020 at 2:32 AM Kunihiko Hayashi
> > > <hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
> > > > On 2020/07/29 4:17, John Stultz wrote:
> > > > > Do you have a upstream driver that you plan to make use this new call?
> > > >
> > > > Unfortunately I don't have an upstream driver using this call.
> > > >
> > > > This call is called from dma-buf heaps "importer" or "customer",
> > > > and I only made an example (do nothing) importer driver
> > > > to test the call.
> > > >
> > > > > We want to have in-tree users of code added.
> > > >
> > > > I think this is a generic way to use non-default CMA heaps, however,
> > > > we need in-tree "importer" drivers to want to use non-default CMA heaps.
> > > > I don't find it from now.
> > >
> > > Yea, I and again, I do agree this is functionality that will be
> > > needed. But we'll need to wait for a user (camera driver, etc which
> > > would utilize the reserved cma region) before we can merge it
> > > upstream. :(  Do let me know if you have an out of tree driver that
> > > would make use of it, and we can see what can be done to help upstream
> > > things.
> >
> > Sorry for late.
> > Before I prepare or find a user driver as "importer",
> > I think something is different in this patch.
> >
> > This patch makes it possible to treat non-default CMA connected to
> > "importer" device with memory-region as dma-buf heaps.
> >
> > However, the allocated memory from this dma-buf heaps can be used
> > for "any" devices, and the "importer" can treat memories from other
> > dma-buf heaps.
> >
> > So, the "importer" and the non-default CMA aren't directly related,
> > and I think an "exporter" for the non-default CMA should be enabled.
> >
> > In paticular, the kernel initializer (as an "exporter") calls
> > dma_heap_add_cma() for all CMAs defined in Devicetree, and
> > the device files associated with each CMA appear under "/dev/dma_heap/".
> > For example:
> >
> >      /dev/dma_heap/linux,cma@10000000
> >      /dev/dma_heap/linux,cma@11000000
> >      /dev/dma_heap/linux,cma@12000000
> >      ...
> >
> > All of these device files can be fairly allocated to any "importer" device.
> >
> > Actually I think that the kernel should executes dma_heap_add_cma()
> > for ALL defined reserved-memory nodes.
> >
> > If this idea hasn't been discussed yet and this is reasonable,
> > I'll prepare RFC patches.
>
> So yes! An earlier version of the CMA heap I submitted did add all CMA
> regions as accessible heaps as you propose here.

Sorry I've missed your submitted patch and previous discussions.

> However, the concern was that in some cases, those regions are device
> specific reserved memory that the driver is probably expecting to have
> exclusive access. To allow (sufficiently privileged, or misconfigured)
> userland to be able to allocate out of that seemed like it might cause
> trouble, and instead we should have CMA regions explicitly exported.

Ah, I see.
Surely if "device-specific" memory is specified as CMA in the devicetree,
it's difficult to avoid any trouble to access it.

> There was some proposal to add a dt property to the reserved memory
> section (similar to linux,cma-default) and use that to do the
> exporting, but other discussions seemed to prefer having drivers
> export it explicitly in a fashion very similar to what your earlier
> patch does. The only trouble is we just need an upstream driver to add
> such a call in the series before we can merge it.

Okay, I understand.
I agree that it seems safe for upstream driver to handle memory that is
only used explicitly.

However, I've not found any drivers to use heaps.
I'll hold this patch until such a driver or other ideas are upstreamed.

Thank you,

---
Best Regards
Kunihiko Hayashi