Re: [RESEND PATCH v1 1/4] dt-bindings: power: reset: Convert reboot-mode to YAML

From: Sebastian Reichel
Date: Tue Aug 25 2020 - 12:21:30 EST


Hi,

Thanks, queued.

-- Sebastian

On Tue, Aug 18, 2020 at 11:54:13AM -0700, Elliot Berman wrote:
> Convert reboot-mode bindings to YAML.
>
> Signed-off-by: Elliot Berman <eberman@xxxxxxxxxxxxxx>
> ---
> .../bindings/power/reset/reboot-mode.txt | 25 ------------
> .../bindings/power/reset/reboot-mode.yaml | 47 ++++++++++++++++++++++
> 2 files changed, 47 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/power/reset/reboot-mode.txt
> create mode 100644 Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/reset/reboot-mode.txt b/Documentation/devicetree/bindings/power/reset/reboot-mode.txt
> deleted file mode 100644
> index de34f27..0000000
> --- a/Documentation/devicetree/bindings/power/reset/reboot-mode.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Generic reboot mode core map driver
> -
> -This driver get reboot mode arguments and call the write
> -interface to store the magic value in special register
> -or ram. Then the bootloader can read it and take different
> -action according to the argument stored.
> -
> -All mode properties are vendor specific, it is a indication to tell
> -the bootloader what to do when the system reboots, and should be named
> -as mode-xxx = <magic> (xxx is mode name, magic should be a none-zero value).
> -
> -For example modes common on Android platform:
> -- mode-normal: Normal reboot mode, system reboot with command "reboot".
> -- mode-recovery: Android Recovery mode, it is a mode to format the device or update a new image.
> -- mode-bootloader: Android fastboot mode, it's a mode to re-flash partitions on the Android based device.
> -- mode-loader: A bootloader mode, it's a mode used to download image on Rockchip platform,
> - usually used in development.
> -
> -Example:
> - reboot-mode {
> - mode-normal = <BOOT_NORMAL>;
> - mode-recovery = <BOOT_RECOVERY>;
> - mode-bootloader = <BOOT_FASTBOOT>;
> - mode-loader = <BOOT_BL_DOWNLOAD>;
> - }
> diff --git a/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> new file mode 100644
> index 0000000..a6c9102
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/reboot-mode.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic reboot mode core map
> +
> +maintainers:
> + - Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> +
> +description: |
> + This driver get reboot mode arguments and call the write
> + interface to store the magic value in special register
> + or ram. Then the bootloader can read it and take different
> + action according to the argument stored.
> +
> + All mode properties are vendor specific, it is a indication to tell
> + the bootloader what to do when the system reboots, and should be named
> + as mode-xxx = <magic> (xxx is mode name, magic should be a non-zero value).
> +
> + For example, modes common Android platform are:
> + - normal: Normal reboot mode, system reboot with command "reboot".
> + - recovery: Android Recovery mode, it is a mode to format the device or update a new image.
> + - bootloader: Android fastboot mode, it's a mode to re-flash partitions on the Android based device.
> + - loader: A bootloader mode, it's a mode used to download image on Rockchip platform,
> + usually used in development.
> +
> +properties:
> + mode-normal:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Default value to set on a reboot if no command was provided.
> +
> +patternProperties:
> + "^mode-.*$":
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> +examples:
> + - |
> + reboot-mode {
> + mode-normal = <0>;
> + mode-recovery = <1>;
> + mode-bootloader = <2>;
> + mode-loader = <3>;
> + };
> +...
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

Attachment: signature.asc
Description: PGP signature