Re: [PATCH v1] extcon: ptn5150: Deduplicate parts of dev_err_probe()

From: Krzysztof Kozlowski
Date: Wed Aug 26 2020 - 08:24:22 EST


On Wed, Aug 26, 2020 at 01:39:10PM +0300, Andy Shevchenko wrote:
> dev_err_probe() is designed to be used like
>
> return dev_err_probe(dev, ret, "Error message\n");
>
> Hence no need to have a separate return statement. Besides that
> dev_err_probe() prints already returned error code, no need to repeat
> that either.
>
> Fixes: 48cbf8c6653c ("extcon: ptn5150: Reduce the amount of logs on deferred probe")

It's an code improvement, optimization, but there is no error here to
fix and Fixes tag would trigger backporting to stable. This patch
should not be backported because it does not meet the backporting
requirements.

With Fixes removed:
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof