Re: [PATCH] perf: correct SNOOPX field offset

From: Al Grant
Date: Wed Aug 26 2020 - 10:34:23 EST


On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote:
Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu:
On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote:
perf_event.h has macros that define the field offsets in the
data_src bitmask in perf records. The SNOOPX and REMOTE offsets
were both 37. These are distinct fields, and the bitfield layout
in perf_mem_data_src confirms that SNOOPX should be at offset 38.

Looks good.

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Probably should have a Fixes: header

Please do so, find the patch that introduced the error, add the Fixes
tag, will help me not having to do it myself :-)

Fixes: 52839e653b562 ("perf tools: Add support for printing new mem_info encodings")