Re: [PATCH v2] mm: memcg: Fix memcg reclaim soft lockup

From: Chris Down
Date: Wed Aug 26 2020 - 14:20:17 EST


Chris Down writes:
Xunlei Pang writes:
Add cond_resched() at the upper shrink_node_memcgs() to solve this
issue, and any other possible issue like meomry.min protection.

I understand the general intent of the patch, but could you clarify your concern around memory protection?

Oh, I see, your concern is just preemption in general rather than a fixing anything for the memory protection side. In which case, go for it, but I agree with Michael that it would be nice to send v3 with a clarifying comment.

Acked-by: Chris Down <chris@xxxxxxxxxxxxxx>