Re: [PATCH v2 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()

From: Tom Rix
Date: Thu Aug 27 2020 - 15:04:33 EST



On 8/27/20 7:32 AM, Luca Ceresoli wrote:
> Current code calls gpiod_get_value() without error checking. Should the
> GPIO controller fail, execution would continue without any error message.
>
> Fix by checking for negative error values.
>
> Reported-by: Tom Rix <trix@xxxxxxxxxx>
> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
>
> ---

Thanks, this looks fine.

Reviewed-by: Tom Rix <trix@xxxxxxxxxx>