Re: [PATCH v2 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure

From: Tom Rix
Date: Thu Aug 27 2020 - 15:09:12 EST



On 8/27/20 7:32 AM, Luca Ceresoli wrote:
> When the DONE pin does not go high after programming to confirm programming
> success, the INIT_B pin provides some info on the reason. Use it if
> available to provide a more explanatory error message.
>
> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
>
> ---
>
> Changes in v2:
> - also check for gpiod_get_value() errors (Tom Rix)

This looks fine.

Reviewed-by: Tom Rix <trix@xxxxxxxxxx>