Re: aarch64 iio build error [PATCH]

From: Randy Dunlap
Date: Sat Aug 29 2020 - 03:02:46 EST


On 8/24/20 12:39 PM, Dave Airlie wrote:
> Hi Jonahtan,
>
> Since rc1 my aarch64 builds have been failing
>
> MODPOST Module.symvers
> ERROR: modpost: "devm_iio_triggered_buffer_setup"
> [drivers/iio/adc/rockchip_saradc.ko] undefined!
> ERROR: modpost: "iio_trigger_notify_done"
> [drivers/iio/adc/rockchip_saradc.ko] undefined!
> ERROR: modpost: "iio_push_to_buffers"
> [drivers/iio/adc/rockchip_saradc.ko] undefined!
> make[2]: *** [/home/airlied/devel/kernel/dim/src/scripts/Makefile.modpost:111:
> Module.symvers] Error
>
> Attached config.
>
> Dave.

I haven't see any fixes for this, although I could have easily
missed a patch.

The patch below should fix these build errors.

---
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Fix build errors in iio/rockchip_saradc by adding selects
to drivers/iio/adc/Kconfig.

Fixes these build errors:

ERROR: modpost: "devm_iio_triggered_buffer_setup"
[drivers/iio/adc/rockchip_saradc.ko] undefined!
ERROR: modpost: "iio_trigger_notify_done"
[drivers/iio/adc/rockchip_saradc.ko] undefined!
ERROR: modpost: "iio_push_to_buffers"
[drivers/iio/adc/rockchip_saradc.ko] undefined!

Reported-by: Dave Airlie <airlied@xxxxxxxxx>
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: jonathan.cameron@xxxxxxxxxx
---
drivers/iio/adc/Kconfig | 4 ++++
1 file changed, 4 insertions(+)

--- linux-next-20200825.orig/drivers/iio/adc/Kconfig
+++ linux-next-20200825/drivers/iio/adc/Kconfig
@@ -865,6 +865,10 @@ config ROCKCHIP_SARADC
tristate "Rockchip SARADC driver"
depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
depends on RESET_CONTROLLER
+ select IIO_BUFFER
+ select IIO_TRIGGER
+ select IIO_TRIGGERED_BUFFER
+ select IIO_TRIGGERED_EVENT
help
Say yes here to build support for the SARADC found in SoCs from
Rockchip.