Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: Add missing clock-cells to PMIC

From: Martin Kepplinger
Date: Sat Aug 29 2020 - 07:47:39 EST


On 28.08.20 21:22, Krzysztof Kozlowski wrote:
> The PMIC node can be a clock provider (for its 32 kHz clock) and authors
> of imx8mq-librem5-devkit.dts apparently wanted this because they added
> input clock and clock-output-names.
>
> Add necessary clock-cells to the PMIC node.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index 377591a0e6e9..40b43625f20f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -285,6 +285,7 @@
> pinctrl-0 = <&pinctrl_pmic>;
> clocks = <&pmic_osc>;
> clock-names = "osc";
> + #clock-cells = <0>;
> clock-output-names = "pmic_clk";
> interrupt-parent = <&gpio1>;
> interrupts = <3 GPIO_ACTIVE_LOW>;
>

Hi Krzysztof,

Reviewed-and-tested-by: Martin Kepplinger <martink@xxxxxxxxx>

thanks for reviewing,

martin