Re: [PATCH v3 3/3] riscv: Add cache information in AUX vector

From: Pekka Enberg
Date: Sun Aug 30 2020 - 04:01:46 EST


On Fri, Aug 28, 2020 at 10:09 AM Zong Li <zong.li@xxxxxxxxxx> wrote:
> +uintptr_t get_cache_geometry(u32 level, enum cache_type type)
> +{
> + struct cacheinfo *this_leaf = get_cacheinfo(level, type);
> + uintptr_t ret = (this_leaf->ways_of_associativity << 16 |
> + this_leaf->coherency_line_size);

You are dereferencing "this_leaf" without checking if it's NULL here.

> +
> + return this_leaf ? ret : 0;
> +}

- Pekka