Re: [PATCH] veth: fix memory leak in veth_newlink()

From: Toshiaki Makita
Date: Sun Aug 30 2020 - 20:16:49 EST


On 2020/08/30 22:13, Rustam Kovhaev wrote:
when register_netdevice(dev) fails we should check whether struct
veth_rq has been allocated via ndo_init callback and free it, because,
depending on the code path, register_netdevice() might not call
priv_destructor() callback

AFAICS, register_netdevice() always goto err_uninit and calls priv_destructor()
on failure after ndo_init() succeeded.
So I could not find such a code path.
Would you elaborate on it?

Thanks,
Toshiaki Makita