Re: [PATCH][next] ath11k: fix missing error check on call to ath11k_pci_get_user_msi_assignment

From: Kalle Valo
Date: Mon Aug 31 2020 - 11:16:59 EST


Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> The return error check on the call to ath11k_pci_get_user_msi_assignment is
> missing. If an error does occur, num_vectors is still set to zero and
> later on a division by zero can occur when variable vector is being
> calculated. Fix this by adding an error check after the call.
>
> Addresses-Coverity: ("Division or modulo by zero")
> Fixes: d4ecb90b3857 ("ath11k: enable DP interrupt setup for QCA6390")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

b2c094582e38 ath11k: fix missing error check on call to ath11k_pci_get_user_msi_assignment

--
https://patchwork.kernel.org/patch/11723523/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches