Re: [PATCH 16/28] wireless: marvell: mwifiex: init: Move 'tos_to_tid_inv' to where it's used

[Kalle Valo]

Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> 'tos_to_tid_inv' is only used in 2 of 17 files it's current being
> included into.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  In file included from drivers/net/wireless/marvell/mwifiex/main.c:23:
>  In file included from drivers/net/wireless/marvell/mwifiex/cmdevt.c:26:
>  In file included from drivers/net/wireless/marvell/mwifiex/util.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/txrx.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/11n.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/wmm.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/11n_aggr.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/join.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_cmd.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_ioctl.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_event.c:25:
>  In file included from drivers/net/wireless/marvell/mwifiex/uap_txrx.c:23:
>  In file included from drivers/net/wireless/marvell/mwifiex/sdio.c:27:
>  In file included from drivers/net/wireless/marvell/mwifiex/sta_tx.c:25:
>  drivers/net/wireless/marvell/mwifiex/wmm.h:41:17: warning: ‘tos_to_tid_inv’ defined but not used [-Wunused-const-variable=]
>  41 | static const u8 tos_to_tid_inv[] = {
> 
>  NB: Snipped for brevity
> 
> Cc: Amitkumar Karwar <amitkarwar@xxxxxxxxx>
> Cc: Ganapathi Bhat <ganapathi.bhat@xxxxxxx>
> Cc: Xinming Hu <huxinming820@xxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

The patch creates two duplicate arrays, this makes it worse than it was
before.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/patch/11723177/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches