Re: [PATCH v3] iomap: Fix WARN_ON_ONCE() from unprivileged users

From: Christoph Hellwig
Date: Mon Aug 31 2020 - 13:26:47 EST


On Mon, Aug 31, 2020 at 01:25:34PM -0400, Qian Cai wrote:
> It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
> unprivileged users which would taint the kernel, or worse - panic if
> panic_on_warn or panic_on_taint is set. Hence, just convert it to
> pr_warn_ratelimited() to let users know their workloads are racing.
> Thank Dave Chinner for the initial analysis of the racing reproducers.
>
> Signed-off-by: Qian Cai <cai@xxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>