RE: [PATCH 1/2] random32: make prandom_u32() output unpredictable

From: David Laight
Date: Tue Sep 01 2020 - 09:14:12 EST


From: Willy Tarreau
> Sent: 01 September 2020 07:43
...
> +/*
> + * Generate some initially weak seeding values to allow
> + * the prandom_u32() engine to be started.
> + */
> +static int __init prandom_init_early(void)
> +{
> + int i;
> + unsigned long v0, v1, v2, v3;
> +
> + if (!arch_get_random_long(&v0))
> + v0 = jiffies;

Isn't jiffies likely to be zero here?

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)